TYP: Add overloads for FT2Font.get_sfnt_table#26540
Merged
oscargus merged 2 commits intomatplotlib:mainfrom Aug 30, 2023
Merged
TYP: Add overloads for FT2Font.get_sfnt_table#26540oscargus merged 2 commits intomatplotlib:mainfrom
oscargus merged 2 commits intomatplotlib:mainfrom
Conversation
Member
|
Stubtest does not like that the typeddicts are "public", as it sees them and not included at runtime. You may be able to fix this with Prefixing the class names with Alternatively, you could define the Typed Dicts in a private module and import them. |
It is in fact a read-only property, not a method.
Member
Author
|
Making them private seems the simplest, and still seems to work for mathtext. |
ksunden
approved these changes
Aug 17, 2023
1 task
oscargus
approved these changes
Aug 30, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 30, 2023
oscargus
added a commit
that referenced
this pull request
Aug 30, 2023
…540-on-v3.8.x Backport PR #26540 on branch v3.8.x (TYP: Add overloads for FT2Font.get_sfnt_table)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This may be perhaps a bit overboard, but I don't expect these dictionaries to change structure very often.
Also, fix type of
Glyph.bbox, which is a property, not a method.PR checklist