Remove Julian date support#26852
Merged
tacaswell merged 1 commit intomatplotlib:mainfrom Sep 21, 2023
Merged
Conversation
dc38c50 to
a9d4f4c
Compare
timhoffm
approved these changes
Sep 21, 2023
Member
|
#26849 should fix azure, merging over the failure. I am curious about why John added this to begin with (they came in in 2006!). |
Member
|
John had a background in Perl, and Julian calendar support is pretty complete in it. Also, Julian day is a bit special because it uses the international date line (180 degrees longitude) instead of the prime meridian as its delimiter for days. This helps with grouping international data by common days, which I'd imagine is useful for people in finance, which John was also involved in for his job. |
Member
|
We maybe could consider ammending the change note to indicate the conversion from our num to Julian days. It's a straightforward offset. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist