TST - Adding test_table() to test_datetimes.py#26898
TST - Adding test_table() to test_datetimes.py#26898iandw wants to merge 5 commits intomatplotlib:mainfrom iandw:TEST---adding-new-axes.table-date-time-test
Conversation
|
Hmmm... This is one that it isn't actually exercising the I think this is correct behavior, and have no real dispersion to testing it, but it is an outlier compared to e.g. Thoughts @tacaswell? |
|
Maybe one can simply use the difference between the column and row heading dates as cell values? I somewhat agree with @ksunden but no harm to test this (although not obvious what could possibly break...). |
|
@iandw thanks a lot for working on this, but I largely agree this isn't testing out handling of datetimes. I don't know what a reasonable test for datetimes would look like on a table as I don't think they map data to a coordinate. |
|
I agree with all the feedback, I wasn't quite sure how to test this for date time either LOL, appreciate the honesty! Will close this for now, it was just a good experience to learn more about contributing to open source at GHC! Thanks all :) |
PR summary
Adding a new test called "test_table" inside of the test_datetimes.py that tests that the axes.table function can generate a plot with datetime arrays.
Part of issue #26859 but does not close this issue fully.
PR checklist