Skip to content

Formatted release note docs#27039

Merged
QuLogic merged 1 commit intomatplotlib:mainfrom
Gaurav-Kumar-Soni:formatting
Oct 17, 2023
Merged

Formatted release note docs#27039
QuLogic merged 1 commit intomatplotlib:mainfrom
Gaurav-Kumar-Soni:formatting

Conversation

@Gaurav-Kumar-Soni
Copy link
Copy Markdown
Contributor

@Gaurav-Kumar-Soni Gaurav-Kumar-Soni commented Oct 9, 2023

PR summary

Reformatted the release notes as per the style conventions at https://matplotlib.org/devdocs/devel/document.html#section-formatting.

PR checklist

github-actions[bot]
github-actions bot reviewed Oct 9, 2023
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@story645
Copy link
Copy Markdown
Member

story645 commented Oct 9, 2023

Thanks for the PR!

In #26862 I put the release files on the please don't format list because I'm not sure if their formatting is historical artifact or due to how released - @QuLogic or @ksunden do you know?

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Oct 11, 2023

These files are fine, but it depends on if it breaks all the files in their toctrees.

@story645
Copy link
Copy Markdown
Member

story645 commented Oct 11, 2023

Was looking at the built docs and didn't seem to but I may be missing something

story645
story645 approved these changes Oct 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna leave merging for a bit in case @QuLogic has an objection but looks good to me.

@Gaurav-Kumar-Soni
Copy link
Copy Markdown
Contributor Author

Gaurav-Kumar-Soni commented Oct 15, 2023

Okie ..

@story645 story645 mentioned this pull request Oct 16, 2023
Closed
16 tasks
QuLogic
QuLogic approved these changes Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed good to me on a quick look through things.

@QuLogic QuLogic added this to the v3.8.1 milestone Oct 17, 2023
@QuLogic QuLogic merged commit 978b402 into matplotlib:main Oct 17, 2023
@QuLogic QuLogic changed the title Formatted docs Formatted release note docs Oct 17, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 17, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 17, 2023
@QuLogic @meeseeksmachine
Backport PR matplotlib#27039: Formatted docs
c6a570d
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Oct 17, 2023

Thanks @Gaurav-Kumar-Soni! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

ksunden added a commit that referenced this pull request Oct 17, 2023
@ksunden
Merge pull request #27113 from meeseeksmachine/auto-backport-of-pr-27…
97e8d17 
…039-on-v3.8.x

Backport PR #27039 on branch v3.8.x (Formatted docs)
@ksunden ksunden mentioned this pull request Nov 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@story645 story645 story645 approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

First Time Contributors
Status: Merged

Milestone

v3.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Gaurav-Kumar-Soni @story645 @QuLogic