FIX: Enable interrupts on macosx event loops#27221
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Oct 30, 2023
Merged
Conversation
Follow the same logic with a context manager for the handling of the event interrupts so that we can re-use the logic from the main loop implementation in the start_event_loop function as well.
ksunden
approved these changes
Oct 30, 2023
Member
|
The issue was milestoned as 3.8.1, the PR was milestoned as 3.9, I'll go ahead and merge it now, but do we wish to backport, @anntzer @greglucas? |
Contributor
|
I think 3.9 is fine, this is not a regression but a new feature? |
Member
|
I think we should backport. |
Contributor
Author
|
@meeseeksmachine backport to v3.8.x |
Contributor
Author
|
@meeseeksdev backport to v3.8.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 30, 2023
rcomer
added a commit
that referenced
this pull request
Oct 30, 2023
…221-on-v3.8.x Backport PR #27221 on branch v3.8.x (FIX: Enable interrupts on macosx event loops)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Follow the same logic with a context manager for the handling of the event interrupts so that we can reuse the logic from the main loop implementation in the
start_event_loopfunction as well.closes #27120
PR checklist