Add missing getter/setter methods to keywords of Figure.__init__ as described in #24617#27997
Add missing getter/setter methods to keywords of Figure.__init__ as described in #24617#27997AlexisMardas wants to merge 8 commits intomatplotlib:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
We discussed issue #24617 in the weekly meeting yesterday, and the general opinion is that this issue needs refinement before it's actually actionable. For this reason, I will close all related open issues for now. This does not mean you can't open another PR in the future or that your solution is necessarily innapropriate, but this will help us focus our efforts. Thank you for your contribution and hope to see you around! |
PR summary
With this PR we attempt to resolve #24617, by adding
get/set_subplotparams,get/set_layoutandget/set_figsizein order to ensure that the Figure getter/setter interface matches better with its constructor. This PR was based on the abandoned #21549PR checklist