TST: Fix image comparison directory for test_striped_lines#28737
Merged
rcomer merged 1 commit intomatplotlib:mainfrom Aug 21, 2024
Merged
TST: Fix image comparison directory for test_striped_lines#28737rcomer merged 1 commit intomatplotlib:mainfrom
rcomer merged 1 commit intomatplotlib:mainfrom
Conversation
timhoffm
approved these changes
Aug 21, 2024
Member
timhoffm
left a comment
There was a problem hiding this comment.
Ok, but I would slightly prefer inlining linewidth as kwarg, analogous to alpha to have all rc state set the same way.
The image comparison directory is determined by `inspect.getfile(func)`, but when a test is wrapped in `rc_context`, the file returned is `contextlib` since that decorator is `contextlib.contextmanager`. Since this test uses `check_figures_equal`, that doesn't break it, but it does break the `triage_tests.py` tool as it cannot find a corresponding baseline image directory. In this case, the context doesn't set anything that would affect figures, so inline the effect of the context as keyword arguments.
5bd9a60 to
541b924
Compare
Member
Author
|
Sure, we can do that. I initially thought this might affect the |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 21, 2024
… test_striped_lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The image comparison directory is determined by
inspect.getfile(func), but when a test is wrapped inrc_context, the file returned iscontextlibsince that decorator iscontextlib.contextmanager. Since this test usescheck_figures_equal, that doesn't break it, but it does break thetriage_tests.pytool as it cannot find a corresponding baseline image directory.Moving the
rc_contextdecorator abovecheck_figures_equalfixes the determined directory. While in this case, the context doesn't set anything that would affect figures, it also makes sense to set the context before figures are created.PR checklist