closes #24617. adds figsize alias and fixed #25091 subplot param getter#28936
closes #24617. adds figsize alias and fixed #25091 subplot param getter#28936EthanAGit wants to merge 3 commits intomatplotlib:mainfrom
Conversation
This is my first open source contribution. I don't know how the setter works as I used someone else's working one, but I did get the getter to pass it's test. Added a figsize alias as well.
|
Thanks for the contribution. We're quite busy getting the 3.10 release out. We'll have a look later. |
|
Without having looked too much into details, at the least, this should pass tests and linting. |
|
Is this issue closed? Can I start working on it? I'm a new contributor and I have some ideas but will get in touch if I have any questions if the issue is still open. |
|
take |
|
We discussed issue #24617 in the weekly meeting yesterday, and the general opinion is that this issue needs refinement before it's actually actionable. For this reason, I will close all related open issues for now. This does not mean you can't open another PR in the future or that your solution is necessarily innapropriate, but this will help us focus our efforts. Thank you for your contribution and hope to see you around! |
First open source contribution. I saw #25901 and noticed that he was in the wrong scope for his subplot getter to be returning the appropriate params, so I set one up in the correct class and gave the figure class a return all subfigure's subplot getter. Also added alias for size_inches -> figsize
[✔️ ] "closes #24617 is in the body of the PR description to link the related issue
[✔️ ] new and changed code is tested
[N/A] Plotting related features are demonstrated in an example
[ N/A] New Features and API Changes are noted with a directive and release note
[ ✔️] Documentation complies with general and docstring guidelines