indicate_inset transform support#29174
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Dec 20, 2024
Merged
Conversation
rcomer
commented
Nov 22, 2024
c8e7643 to
ba851c1
Compare
rcomer
commented
Nov 22, 2024
|
|
||
|
|
||
| @image_comparison(['zoom_inset_transform.png'], remove_text=True, style='mpl20', | ||
| tol=0.01) |
Member
Author
There was a problem hiding this comment.
MacOS tests need the 0.01 tolerance.
470b488 to
0d57221
Compare
0d57221 to
95ed490
Compare
rcomer
commented
Nov 23, 2024
| # Set axes on the rectangle (required for some external transforms to work) as | ||
| # well as the InsetIndicator artist. | ||
| self.rectangle.axes = new_axes | ||
| artist.Artist.axes.fset(self, new_axes) |
Member
Author
There was a problem hiding this comment.
I copied the setter logic here from the artist within artist example. I would not have figured it out by myself - thanks @QuLogic for putting it in the example!
greglucas
approved these changes
Dec 5, 2024
5 tasks
QuLogic
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
indicate_insetdocstring, as we are definitely defaulting to transData.main, my new image test givesaxesproperty on the rectangle so that Cartopy transforms will work, and we can do things likePR checklist