Skip to content

Cranky pep8#2930

Merged
pelson merged 2 commits intomatplotlib:masterfrom
tacaswell:cranky_pep8
Mar 27, 2014
Merged

Cranky pep8#2930
pelson merged 2 commits intomatplotlib:masterfrom
tacaswell:cranky_pep8

Conversation

@tacaswell
Copy link
Copy Markdown
Member

@tacaswell tacaswell commented Mar 27, 2014

fixed E713 and E714 because they seem legit.

Everything else was either picking exclusively (until I gave up) on comments or was complaining about

Squelched error code reasoning
E256 entirely formatting on comments, flags on #### stuff
E111, E112, E113 flags entirely on comments, mostly ones that had to get wrapped due to line length issues
E129 issues with continued lines hitting the next true indent, could be sold on really fixing these
E131 issues with indentation of continuation lines not being just right. I think there are common situations where it is in fact impossible to satisfy both E129 and E131

E11{1,2,3} is catching things like

some_code() # this is a long comment
            # explaining the code that got
            # wrapped like this due to line
            # length issues

And I think that

if (food and 
    bar):
    some_stuff()

can not satisfy both E129 and E131

@tacaswell
PEP8 : fixed all E71[3,4] failures
24085ac
@tacaswell
PEP8 : Squelch spurious tests
6464e2d 
The new ignore tests (E111, E112, E113, E265) are just picking up
style infractions on the comments.
@tacaswell tacaswell mentioned this pull request Mar 27, 2014
Merged
@tacaswell
Copy link
Copy Markdown
Member Author

tacaswell commented Mar 27, 2014

And now it looks like rabbitmq.com which the travis vm talks to while running apt-get update is down which is why everything is erroring out in < 1min.

@tacaswell tacaswell added this to the v1.4.0 milestone Mar 27, 2014
pelson added a commit that referenced this pull request Mar 27, 2014
@pelson
Merge pull request #2930 from tacaswell/cranky_pep8
7d6d594 
Cranky pep8
@pelson pelson merged commit 7d6d594 into matplotlib:master Mar 27, 2014
@tacaswell tacaswell deleted the cranky_pep8 branch March 27, 2014 18:31
@tacaswell tacaswell mentioned this pull request Sep 1, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tacaswell @pelson