MNT: Deprecate other capitalization than "None" in matplotlibrc#29529
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Jan 28, 2025
Merged
MNT: Deprecate other capitalization than "None" in matplotlibrc#29529QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
61a0829 to
93e01c8
Compare
Member
|
I appear to have infiltrated your commit somehow 😕 |
story645
reviewed
Jan 27, 2025
Member
Author
Not sure how this happend 😆. I've possibly messed up with --amend when creating the PR, but don't remember. If it's ok for you, I would not bother. |
Member
It seems like you'll have to update to fix the linting anyway, so to fix, use |
The `*_or_None` validators have accepted any capitalization of the string "none" as input. This is overly permissive and will likely lead to conflicts in the future because we cannot distinguish between resolving to `None` and `"none"` which may be need for some parameters in the future. Inspired by matplotlib#29481.
9225687 to
5c8c9b5
Compare
scottshambaugh
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
*_or_Nonevalidators have accepted any capitalization of the string "none" as input. This is overly permissive and will likely lead to conflicts in the future because we cannot distinguish between resolving toNoneand"none"which may be need for some parameters in the future.Inspired by #29481.