Add 3D scatter test for cmap update#30062
Merged
oscargus merged 1 commit intomatplotlib:mainfrom May 18, 2025
Merged
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
dstansby
approved these changes
May 17, 2025
Member
dstansby
left a comment
There was a problem hiding this comment.
Thanks a lot - looks good to me.
Member
|
Thanks and congratulations on your first merged PR in Matplotlib. Looks that there may be two soon. Hoping to see you around! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR adds a new test to verify that changing the colormap of a 3D scatter plot (
Axes3D.scatter) after drawing the figure properly updates the face colors.Why is this change necessary?
There was previously no test ensuring that colormap updates on 3D scatter plots are reflected after a figure draw. This test ensures consistency with 2D behavior and guards against regressions.
What problem does it solve?
Confirms that calling
set_cmap()after drawing does in fact update the plotted colors in 3D, which has historically been a bug but seems to be fixed.What is the reasoning for this implementation?
The test draws a 3D scatter plot with an initial colormap (
'jet'), forces a draw, changes the colormap to'viridis', and compares it against a reference plot created directly with'viridis'.This ensures the update mechanism behaves correctly post-render.
Minimal example
Closes #18931
PR checklist
edgecolor='face'#18931" is in the body of the PR description to link the related issue