Skip to content

Backport PR #28554 on branch v3.10.x (BLD: Enable wheels on Windows-on-ARM)#30352

Merged
tacaswell merged 2 commits intomatplotlib:v3.10.xfrom
meeseeksmachine:auto-backport-of-pr-28554-on-v3.10.x
Jul 25, 2025
Merged

Backport PR #28554 on branch v3.10.x (BLD: Enable wheels on Windows-on-ARM)#30352
tacaswell merged 2 commits intomatplotlib:v3.10.xfrom
meeseeksmachine:auto-backport-of-pr-28554-on-v3.10.x

Conversation

@meeseeksmachine
Copy link
Copy Markdown
Contributor

Backport PR #28554: BLD: Enable wheels on Windows-on-ARM

@lumberbot-app lumberbot-app bot added this to the v3.10.4 milestone Jul 24, 2025
@lumberbot-app lumberbot-app bot added the CI: Run cibuildwheel Run wheel building tests on a PR label Jul 24, 2025
@ksunden
Copy link
Copy Markdown
Member

ksunden commented Jul 25, 2025

Failure is real, contourpy does not provide windows arm wheels on python 3.10.

As such, I think I lean towards not bothering to backport this... we were already kind of on the fence. I'd rather keep the versions of python we have in the 3.10 series and not add a new platform than either drop a python version or deal with complicating CI config...

Any objections to just not backporting? (@tacaswell @QuLogic in particular)

@tacaswell
Copy link
Copy Markdown
Member

what does the patch to skip py310 on arm look like?

@ksunden
Copy link
Copy Markdown
Member

ksunden commented Jul 25, 2025

I think it would be adding the following line to the 3.10 step (this is a pared down version of the pypy condition which was edited already to exclude win-arm).

        if: matrix.os != 'windows-11-arm'

Dependencies do not provide wheels, so do not try to build them ourselves (was failing because it was trying to install from nightlies, and no compatible version was provided).
@ksunden
Copy link
Copy Markdown
Member

ksunden commented Jul 25, 2025

I have tried it, now to see if it works, if it does we can go forward with the backport, if not probably not worth further troubleshooting (barring simple things like yaml syntax errors).

@tacaswell tacaswell merged commit 9e38af6 into matplotlib:v3.10.x Jul 25, 2025
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Run cibuildwheel Run wheel building tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants