TST: Remove redundant font tests#30513
Merged
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom Mar 26, 2026
Merged
Conversation
c9802ea to
ec45d5f
Compare
ec45d5f to
b7f089c
Compare
- `test_backend_ps::test_type3_font` is covered by `test_backend_ps::test_multi_font_type3` - `test_text::test_pdf_chars_beyond_bmp` is covered by `test_backend_pdf::test_multi_font_type3` and `test_backend_pdf::test_multi_font_type42` - `test_text::test_pdf_kerning` is covered by `test_backend_pdf::test_kerning` - `test_text::test_pdf_type42_kerning` is covered by `test_backend_pdf::test_kerning`
b7f089c to
9d23373
Compare
Member
Author
|
Unfortunately, the pre-loading of images doesn't handle this side having deleted the image, but I think this PR can be confirmed to be okay by hand. |
ksunden
approved these changes
Mar 6, 2026
Member
Author
|
Since this may or may not cause conflicts with the preload, going to wait to merge this one until the last minute. |
tacaswell
approved these changes
Mar 19, 2026
Member
Author
|
I ran some tests locally and there shouldn't be any conflicts with the image preloading, so long as it's rebased on top of this, so I'll merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
I extracted this out of #30512 because it was causing issues with the pre-loading of test images. I may update this as/when I find more redundant tests.
test_backend_ps::test_type3_fontis covered bytest_backend_ps::test_multi_font_type3test_text::test_pdf_chars_beyond_bmpis covered bytest_backend_pdf::test_multi_font_type3andtest_backend_pdf::test_multi_font_type42test_text::test_pdf_kerningis covered bytest_backend_pdf::test_kerningtest_text::test_pdf_type42_kerningis covered bytest_backend_pdf::test_kerningPR checklist