mplot3d: refresh projected axis positions before tightbbox#31342
mplot3d: refresh projected axis positions before tightbbox#31342Donj63000 wants to merge 1 commit intomatplotlib:mainfrom
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on gitter for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
|
Hi, please fill out our PR template when opening a PR. Specifically, your description is missing the AI disclosure section. |
|
⏰ This pull request might be automatically closed in two weeks from now. Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable. Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬 To increase the chance of a productive review:
As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code. If you substantially improve this PR within two weeks, leave a comment and a team member may remove the |
|
Hi, sorry for the inconvenience and for the time this may have cost you. |
|
No need to create a new PR, you can update this PR. |
Fixes #31277
The issue comes from
Axis3D.get_tightbbox()using stale artist extents beforethe projected 3D axis positions have been refreshed. In constrained layout, this
can make the computed bbox too small and lead to overlaps between 3D tick labels
and the title of the following subplot.
This patch refreshes the projected axis geometry before computing the tightbbox,
so layout uses updated extents.
It also adds regression tests covering:
Axis3D.get_tightbbox()before and after draw