Skip to content

BLD: Temporarily pin setuptools-scm<10#31401

Merged
QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic:pin-setuptools-scm
Mar 27, 2026
Merged

BLD: Temporarily pin setuptools-scm<10#31401
QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic:pin-setuptools-scm

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 26, 2026

PR summary

This is currently causing warnings at runtime in the editable install, which breaks almost all tests.

We'll need this until at least pypa/setuptools-scm#1314 is fixed, or we come up with a better fix.

AI Disclosure

None

PR checklist

This is currently causing warnings at runtime in the editable install,
which breaks almost all tests.
Copy link
Contributor

@scottshambaugh scottshambaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining CI failure looks real but unrelated.

@QuLogic
Copy link
Member Author

QuLogic commented Mar 27, 2026

We should probably investigate it but it's not consistently failing.

@QuLogic
Copy link
Member Author

QuLogic commented Mar 27, 2026

I'll merge as CI fixes only need one approval.

@QuLogic QuLogic merged commit 443c728 into matplotlib:main Mar 27, 2026
51 of 53 checks passed
@QuLogic QuLogic deleted the pin-setuptools-scm branch March 27, 2026 05:44
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 27, 2026

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 443c728e3af423a882d51e758c88577959e0c7d1
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #31401: BLD: Temporarily pin setuptools-scm<10'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-31401-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR #31401 on branch v3.10.x (BLD: Temporarily pin setuptools-scm<10)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants