FIX: Guard against already-removed labels in ContourSet.remove()#31427
Open
buddy0452004 wants to merge 3 commits intomatplotlib:mainfrom
Open
FIX: Guard against already-removed labels in ContourSet.remove()#31427buddy0452004 wants to merge 3 commits intomatplotlib:mainfrom
buddy0452004 wants to merge 3 commits intomatplotlib:mainfrom
Conversation
Contributor
|
@buddy0452004 I was working on a similar fix based on the discussion here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When contour labels are manually removed before calling CS.remove(), matplotlib still tries to remove them again internally, causing a ValueError.
The root cause is that super().remove() detaches the contour from the axes, setting self.axes to None. Any subsequent access to self.axes.texts then crashes. The fix saves the axes reference before calling super().remove(), then uses it safely with a None check.
Closes #31404
AI Disclosure
No AI used.
PR Checklist