WIP: Adjust nticks based on length of axis#5494
Closed
mdboom wants to merge 4 commits intomatplotlib:masterfrom
Closed
WIP: Adjust nticks based on length of axis#5494mdboom wants to merge 4 commits intomatplotlib:masterfrom
mdboom wants to merge 4 commits intomatplotlib:masterfrom
Conversation
Contributor
|
Very nice to see some work on this, adjusting ticks always takes quite a lot of time. Feature request: ability to disallow ticks near the end of an axis, this is very helpful when stacking axes without any hspace/wspace, because else the ticklabels are overlapping. |
Member
Author
|
I'm going to close this and move it to the style-change branch. It's not possible to make this backward compatible without some other changes over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bit of a chicken and egg problem here. You don't know how many ticks you can fit if you don't know what the tick labels contain. And you don't know what the tick labels contain until you know how many ticks there are.
Therefore this is just based on a heuristic that the text will have an aspect ratio of around 4:1. Probably not always true, and there are perhaps better ways to estimate based on what the tick formatter actually is, or by rendering just one of them and using that.