Conversation
|
|
|
To trim this down a bit, the text changes seem consistent with those on which are mostly non-existent on 2.0, but there are a few more other changes.
I'm not sure why I don't understand why |
|
Thanks for looking at this. I think #5583 never got fully backported to 2.0.x. I've done that, now I'll rebase this on the new 2.0.x and see how that pans out. |
I'm not sure I follow. It exists in both places, AFAICT. |
61cc364 to
65dc69a
Compare
|
I've redone this after backporting #5583 to v2.0.x and there were far fewer conflicts this time -- mainly just in tests that exist on master but not 2.0.x. |
65dc69a to
57c33f0
Compare
They didn't exist when I looked ;)
This file is still different. Maybe including #5651 here will make them more consistent? For some reason, GitHub is not show the backport of #5433 here even though it does say it's part of this PR if you go to your fork and look at the commit directly. Anyway... |
57c33f0 to
a977b8f
Compare
Unless I'm misunderstanding, I think this is no longer the case. Different from what? On this branch vs. upstream/master? |
|
I think this is green again. @QuLogic: I think I've addressed all that you found, but let me know if otherwise. |
|
I am seeing 3 files different |
|
I'll just forcibly pick those 3 files from master (since I think the differences are all non-visible anyway) and see how that goes... |
c5a3fd2 to
8ccbe8c
Compare
|
Ok. I think we're finally good-to-go here. |
|
I don't see where those other 3 files got pulled in |
|
maybe #5621 should be backported to 2.0.x and then this backport rebased on top of it? That is the source of the missing png |
Lower test tolerance
8ccbe8c to
164222a
Compare
I checked them out directly from master and amended the commit it order to reduce the amount of large diff.
Sure. Done. |
|
Ah, sorry, I was confused |
|
No worries -- I was confused as well. This massive PRs are hard to manage... |
Running this through a PR to give it proper Travis testing.