Skip to content

Fix twin remove#5682

Merged
WeatherGod merged 5 commits intomatplotlib:v1.5.xfrom
tacaswell:fix_twin_remove
Dec 15, 2015
Merged

Fix twin remove#5682
WeatherGod merged 5 commits intomatplotlib:v1.5.xfrom
tacaswell:fix_twin_remove

Conversation

@tacaswell
Copy link
Copy Markdown
Member

also adds tests to cbook.Grouper

This addresses half of #1312 use case by providing a clean way to remove shared axes.

This test touches the internals, if Grouper gets refactored this
test should be removed.
This adds clean up of the shared axes `Grouper` objects as part
of removing an axes.

`_reset_loc_form` is required because the locator/formatters end up
bound to the axis objects of the last axes object (all of the Axes in
the group share the same formatter/locator objects but have different
Axis objects so that all but one of the Axis objects can be made not
visible to not over-draw).  If these are not re-bound to a still visible
axes then changing the limits will change the view limits, but not the
tick locations.

closes matplotlib#5663
@tacaswell tacaswell added this to the Critical bugfix release (1.5.1) milestone Dec 15, 2015
@mdboom
Copy link
Copy Markdown
Member

mdboom commented Dec 15, 2015

Restarted Python 3.3 on Travis (which looks unrelated). 👍 on merging once passing.

WeatherGod added a commit that referenced this pull request Dec 15, 2015
@WeatherGod WeatherGod merged commit f9e405e into matplotlib:v1.5.x Dec 15, 2015
@tacaswell tacaswell deleted the fix_twin_remove branch December 15, 2015 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants