Using to_rgba rather than to_rgb in figure_edit#6589
Closed
dwgoon wants to merge 1 commit intomatplotlib:masterfrom
Closed
Using to_rgba rather than to_rgb in figure_edit#6589dwgoon wants to merge 1 commit intomatplotlib:masterfrom
dwgoon wants to merge 1 commit intomatplotlib:masterfrom
Conversation
Member
Contributor
Member
|
The milestones got a bit crossed as we backported #6382 to 2.0. |
Author
|
Thanks for the reviews :) |
Contributor
|
I guess it's a good test as to whether I actually broke backwards compatibility :) but it probably makes sense to just merge-and-backport #6383 too. |
Author
|
It already has a solution! I wish it will be applied as soon as possible. |
Merged
Member
|
Closing as covered by #6383 and friends. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OS: Windows 7 (64bit)
Python: Anaconda, Python 3.4.4 (64bit)
matplotlib: 1.5.1 (version used for this test)
matplotlib backend: Qt4Agg or Qt5Agg
If I set "markerfacecolor" as "none" (not None) for plotting, I get the following exception when I push the editing button of toolbar.
Here is the example code for testing.
One solution is to use "to_rgba" of colorConverter in "matplotlib\backends\qt_editor\figureoptions.py" rather than "to_rgb". It is because "to_rgb" does not handle the "none" option as a transparent color, whereas "to_rgba" does.