Merged
Conversation
colors.rgb2hex and colors.hex2color are trivial aliases of to_hex and to_rgb.
afvincent
approved these changes
Nov 4, 2017
Contributor
There was a problem hiding this comment.
Looks good to me.
Weren't the docstrings of these aliases functions quite deceptive anyway? hex2color('gray') as well as rgb2hex('gray') are working properly, despite what their docstrings suggested (and despite what their name still do, but that is another story...). At least with this patch the docstrings will be correct.
Member
|
Hmm, these no longer appear in the documentation - is there any way to put them back? |
Contributor
Author
|
They were intentionally removed from the docs in #6382. |
dopplershift
approved these changes
Nov 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
colors.rgb2hex and colors.hex2color are trivial aliases of to_hex and
to_rgb.
PR Summary
PR Checklist