This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Refactor HomeserverConfig so it can be typechecked#6137
Merged
Conversation
…synapse into hawkowl/config-cleanup
richvdh
suggested changes
Oct 7, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
looks good, but a few questions
| [mypy-signedjson.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| [mypy-prometheus_client.*] |
Member
There was a problem hiding this comment.
why are we adding this sort of thing?
Contributor
Author
There was a problem hiding this comment.
because we don't have type stubs for these modules, so therefore we don't want to typecheck them. We don't want to ignore missing imports completely, just on dependencies without type hints.
Member
There was a problem hiding this comment.
ok, but it just doesn't seem related to the subject of the PR and the text of the changelog.
I guess it's necesary because of https://github.com/matrix-org/synapse/pull/6137/files#diff-b91f3d5bd63fcd17221b267e851608e8R169?
Co-Authored-By: Richard van der Hoff <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that static typing can now functionally be used, if we define type stubs/mypy can infer things