Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix appservice room list pagination#6154

Merged
erikjohnston merged 2 commits intodevelopfrom
erikj/fix_appservice_pagination
Oct 2, 2019
Merged

Fix appservice room list pagination#6154
erikjohnston merged 2 commits intodevelopfrom
erikj/fix_appservice_pagination

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

We need to add to query_args in the same order as the various clauses appear in the SQL.

@erikjohnston erikjohnston requested a review from a team October 2, 2019 14:48
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tests would be nice.

@erikjohnston erikjohnston merged commit dca7e32 into develop Oct 2, 2019
@erikjohnston erikjohnston deleted the erikj/fix_appservice_pagination branch January 9, 2020 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants