This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix /federation/v1/state for recent room versions#6170
Merged
Conversation
Turns out this endpoint was completely broken for v3 rooms. Hopefully this re-signing code is irrelevant nowadays anyway.
59c9ccc to
c4956d1
Compare
Member
Author
|
(test in matrix-org/sytest#716) |
Member
|
This PR is consistently failing on the Or perhaps it's just the flaky public rooms directory... |
Member
Author
|
the latter, I think |
Member
|
* tries to run the tests again |
97eda27 to
f4b41f7
Compare
This reverts commit f4b41f7.
hawkowl
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this endpoint was completely broken for v3 rooms. Hopefully this
re-signing code is irrelevant nowadays anyway.