This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix presence timeouts when synchrotron restarts.#6212
Merged
Conversation
Handling timeouts would fail if there was an external process that had timed out, e.g. a synchrotron restarting. This was due to a couple of variable name typoes. Fixes #3715.
88e48a5 to
1daed7f
Compare
richvdh
approved these changes
Oct 17, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
that was easier than I expected
|
Thank you so much, highly appreciated! |
|
Do you include that into the 1.4.1 release? |
Member
|
No, this will not be in the 1.4.1 release, which is just fixing a regression introduced in 1.4.0. We hope to release a 1.5.0 next week. |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling timeouts would fail if there was an external process that had
timed out, e.g. a synchrotron restarting. This was due to a couple of
variable name typoes.
Fixes #3715.