This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Conversation
hawkowl
reviewed
Oct 19, 2019
| self.prev_state_events = [] | ||
| self.rejected = False | ||
| self.app_service = None | ||
| state_group = attr.ib(default=None) |
Contributor
There was a problem hiding this comment.
just a note: you can annotate the types in this with type= -- for the optional ones you want to use typing.Optional[int] or whatever. mypy can read that info, and also some editor IDEs can as well, so it can be worth it :)
Member
Author
There was a problem hiding this comment.
mmm, good to know. I'll consider it next time ;)
hawkowl
previously requested changes
Oct 19, 2019
Contributor
hawkowl
left a comment
There was a problem hiding this comment.
On the old deps builders:
builtins.TypeError: attrib() got an unexpected keyword argument 'factory'
This is an 18.1.0 feature in attrs and we depend on a min of 17.4. We should probably upgrade to 18.1, or fix this here to use default=attrs.Factory() -- your choice (I prefer the former :) ).
erikjohnston
approved these changes
Oct 28, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '9aee28927': Convert EventContext to attrs (#6218)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main driver for this was to get a sensible
__repr__, but the improved type-safety doesn't hurt.