This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Refactor storage layer to support multiple databases#6231
Merged
erikjohnston merged 11 commits intodevelopfrom Oct 23, 2019
Merged
Refactor storage layer to support multiple databases#6231erikjohnston merged 11 commits intodevelopfrom
erikjohnston merged 11 commits intodevelopfrom
Conversation
This is in preparation for having multiple data stores that offer different functionality, e.g. splitting out state or event storage.
402067b to
acf47c7
Compare
richvdh
reviewed
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial refactor that starts the split out of
DataStoreinto the concept of "data stores". Broadly, this moves all the stores insynapse.storageintosynapse.storage.data_stores.mainand fixes upprepare_databaseto correctly apply schemas from multiple data stores.The commits should be independently reviewable. The first one is the big one, and is the moving of files. The only changes are that helper classes/exceptions/etc that are imported from outside
synapse.storageget left insynapse.storagerather than getting moved into a data store (the aim being that things outside storage rarely if ever need to know about the concept of data stores).Currently this still exports the same
DataStoreinsynapse.storage, but splitting that out some more is a job for a separate PR