This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Depublish a room from the public rooms list when it is upgraded#6232
Merged
anoadragon453 merged 13 commits intodevelopfrom Nov 1, 2019
Merged
Depublish a room from the public rooms list when it is upgraded#6232anoadragon453 merged 13 commits intodevelopfrom
anoadragon453 merged 13 commits intodevelopfrom
Conversation
richvdh
previously approved these changes
Oct 23, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
I swear I reviewed this earlier
LGTM, though it now has conflicts :/
richvdh
reviewed
Oct 23, 2019
This prevents us from checking for an upgraded room every time a user on the homeserver joins a new room, which is unnecessary. We only need to check once per room, instead of on every local join
656bbe4 to
3d5ca5a
Compare
Rooms on remote servers were getting the old room depublished from the room directory, but weren't getting new rooms auto-published to the room directory.
…m_upgrade_depublishing
Member
Author
|
@richvdh This has changed quite a bit since your approval, so I'd like another review if possible. I've changed the check to being on when a user joins a room the server already knows about and one they haven't, to only checking when a room is upgraded and upon your server seeing it for the first time. |
richvdh
previously requested changes
Oct 30, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
looks good, modulo a couple of nits
Co-Authored-By: Richard van der Hoff <[email protected]>
richvdh
previously requested changes
Oct 31, 2019
richvdh
approved these changes
Oct 31, 2019
anoadragon453
added a commit
to matrix-org/sytest
that referenced
this pull request
Nov 1, 2019
…upgrade (#729) Synapse PR: matrix-org/synapse#6232
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'ace947e8d': Depublish a room from the public rooms list when it is upgraded (#6232)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4948
Remove a room from the public rooms list on a server when a user from that server joins the upgraded room, and when that user has permission to remove the listing in the old room.
Also fix an incorrect docstring.
TODO: