This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Remove repeated calls to config.stats_enabled.#6255
Merged
erikjohnston merged 3 commits intorelease-v1.5.0from Oct 25, 2019
Merged
Remove repeated calls to config.stats_enabled.#6255erikjohnston merged 3 commits intorelease-v1.5.0from
erikjohnston merged 3 commits intorelease-v1.5.0from
Conversation
Turns out that fetching variables from the config object is expensive, so doing it once at startup avoids unnecessary work.
richvdh
added a commit
that referenced
this pull request
Oct 28, 2019
Synapse 1.5.0rc2 (2019-10-28) ============================= Bugfixes -------- - Update list of boolean columns in `synapse_port_db`. ([\#6247](#6247)) - Fix /keys/query API on workers. ([\#6256](#6256)) - Improve signature checking on some federation APIs. ([\#6262](#6262)) Internal Changes ---------------- - Move schema delta files to the correct data store. ([\#6248](#6248)) - Small performance improvement by removing repeated config lookups in room stats calculation. ([\#6255](#6255))
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '87259b3a3': Fix tests Newsfile Remove repeated calls to config.stats_enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that fetching variables from the config object is expensive,
so doing it once at startup avoids unnecessary work.