Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Make room directory search case insensitive#6268

Merged
erikjohnston merged 4 commits intorelease-v1.5.0from
erikj/case_insensitive_room_dir
Oct 29, 2019
Merged

Make room directory search case insensitive#6268
erikjohnston merged 4 commits intorelease-v1.5.0from
erikj/case_insensitive_room_dir

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston commented Oct 29, 2019

This doesn't use ILIKE because sqlite.

Fixes #6265

@erikjohnston erikjohnston requested a review from a team October 29, 2019 10:25
Copy link
Copy Markdown
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Comment thread tox.ini Outdated
deps =
flake8
black
black==19.3b0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that explains why we're pinning Black to this version?

@RichGriese
Copy link
Copy Markdown

You folks are awesome. I just tested it on macOS desktop on the live riot/matrix.org site... and the search IS now case insensitive. Right on. Enjoy life... eat out more often!

@erikjohnston erikjohnston deleted the erikj/case_insensitive_room_dir branch January 9, 2020 15:47
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '1652c8c1f':
  Add comment as to why we're pinning black in tests
  Pin black version
  Newsfile
  Make room directory search case insensitive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants