Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Update email section of INSTALL.md about account_threepid_delegates#6272

Merged
anoadragon453 merged 2 commits intomasterfrom
anoa/update_install_email_section
Oct 30, 2019
Merged

Update email section of INSTALL.md about account_threepid_delegates#6272
anoadragon453 merged 2 commits intomasterfrom
anoa/update_install_email_section

Conversation

@anoadragon453
Copy link
Copy Markdown
Member

Update the email section of INSTALL.md to reflect the changes made to Synapse's email setup, namely that it now handles email registration by itself, and that it will need to be configured in some sense in order for those features to be enabled.

@anoadragon453 anoadragon453 self-assigned this Oct 29, 2019
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

words are hard

Comment thread INSTALL.md Outdated
Comment thread INSTALL.md Outdated
Comment thread INSTALL.md Outdated
Comment thread INSTALL.md Outdated
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Oct 29, 2019

also: I suggest targeting master for this

@anoadragon453 anoadragon453 requested a review from richvdh October 29, 2019 14:05
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise. remember to change the target branch to master.

Comment thread INSTALL.md Outdated
@anoadragon453 anoadragon453 changed the base branch from develop to master October 30, 2019 11:08
@anoadragon453 anoadragon453 changed the base branch from master to develop October 30, 2019 11:08
@anoadragon453 anoadragon453 force-pushed the anoa/update_install_email_section branch from 9d7370b to 070a248 Compare October 30, 2019 11:13
@anoadragon453 anoadragon453 changed the base branch from develop to master October 30, 2019 11:15
@anoadragon453
Copy link
Copy Markdown
Member Author

Merging on account of broken CI on master is ok.

@anoadragon453 anoadragon453 merged commit 7e17959 into master Oct 30, 2019
@anoadragon453 anoadragon453 deleted the anoa/update_install_email_section branch October 30, 2019 11:38
babolivier pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants