This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix log line that was printing undefined value#6278
Merged
anoadragon453 merged 5 commits intodevelopfrom Oct 30, 2019
Merged
Conversation
erikjohnston
approved these changes
Oct 30, 2019
Co-Authored-By: Erik Johnston <[email protected]>
anoadragon453
added a commit
that referenced
this pull request
Oct 30, 2019
…ger_warning * 'develop' of github.com:matrix-org/synapse: Fix log line that was printing undefined value (#6278) Update CI to run isort on scripts and scripts-dev (#6270) Fix small typo in comment (#6269) Fix typo in domain name in account_threepid_delegates config option (#6273) Remove redundant arguments to CI's flake8 (#6277) Handle FileNotFound error in checking git repository version (#6284) Don't return coroutines Newsfile Port receipt and read markers to async/wait Make concurrently_execute work with async/await Newsfile Port federation_server to async/await Newsfile Port room rest handlers to async/await Newsfile Port replication http server endpoints to async/await
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This log line was trying to print
event, buteventwon't exist if the abovetry:failed, which is the only time this log line would occur in the first place.Change log line to use
room_idinstead, which I think is largely the original intention anyway?