This repository was archived by the owner on Apr 26, 2024. It is now read-only.
fix hidden field in devices table for older sqlite#6313
Merged
Conversation
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
…ite_schema * commit 'fa7e52caf': add changelog fix hidden field in devices table for older sqlite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6302
I've tested sqlite 3.27.2 (Debian buster) and sqlite 3.16.2 (Debian stretch), both doing upgrades of v1.4.1 -> v1.5.0 -> this branch, as well as v1.4.1 -> this branch. All the tests resulted in the correct behaviour of the
hiddenfield set to 0 instead of'FALSE'.I was unable to figure out a way to avoid doing the db upgrade step from
56/hidden_devices.sqlwhen going v1.4.1 -> this branch. Anything that I thought of would break something in sqlite and/or postgresql. So we're stuck with doing56/hidden_devices.sqlfollowed immediately by56/hidden_devices_fix.sql.sqlitefor sqlite database, which has to copy the wholedevicestable.