This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Strip overlong OpenGraph data from url preview#6331
Merged
Conversation
... to stop people causing DoSes with malicious web pages
erikjohnston
approved these changes
Nov 5, 2019
Member
erikjohnston
left a comment
There was a problem hiding this comment.
It'd be nice if we truncated long titles, but this works for now
| b"<title>" + b"x" * 2000 + b"</title>" | ||
| b'<meta property="og:description" content="hi" />' | ||
| b"</head></html>" | ||
| ) |
Member
There was a problem hiding this comment.
(You can use multiline b"""....""" byte quotes fwiw)
babolivier
suggested changes
Nov 5, 2019
Co-Authored-By: Brendan Abolivier <[email protected]> Co-Authored-By: Erik Johnston <[email protected]>
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '02f99906f': Apply suggestions from code review Strip overlong OpenGraph data from url preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to stop people causing DoSes with malicious web pages