This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Make numeric user_id checker start at @0, and don't ratelimit on checking#6338
Merged
anoadragon453 merged 5 commits intodevelopfrom Nov 6, 2019
Merged
Make numeric user_id checker start at @0, and don't ratelimit on checking#6338anoadragon453 merged 5 commits intodevelopfrom
anoadragon453 merged 5 commits intodevelopfrom
Conversation
erikjohnston
previously requested changes
Nov 6, 2019
Member
erikjohnston
left a comment
There was a problem hiding this comment.
Just some niggles. Can you also put a limit on the autogenerate user ID loop please? That way if we do hit the bug again we will only loop a few times before giving up, rather than taking out the servuce.
erikjohnston
previously requested changes
Nov 6, 2019
erikjohnston
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5225
This PR:
find_next_generated_user_id_localpartto start at@0instead of@1, so we don't tell people it's ok to register@0and then they proceed to try every number up the entire tableregister_with_storeand moved it up and out, also eliminating the need to have an explicit check for application service registration.