Skip to content

chore: add 2 new examples that doesn't use maxGraph defaults#493

Merged
tbouffard merged 6 commits intomainfrom
refactor/add_more_examples
Aug 16, 2024
Merged

chore: add 2 new examples that doesn't use maxGraph defaults#493
tbouffard merged 6 commits intomainfrom
refactor/add_more_examples

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 4, 2024

Provide both a new TypeScript example (built with Vite) and a new JavaScript example (built with webpack) that don't use default plugins and default style configurations:

  • edge marker
  • edge style (connector)
  • perimeter
  • shape

It will show the progress made in improving the tree-shaking for applications that don't want to use maxGraph's default configuration.

Also improve the existing TypeScript example

  • improve the README file
  • update the page title
  • improve style declaration: remove wrong todo and use constants

Screenshots of the new example

No registered shapes: so use the default one (rectangle)
No perimeter, so edges start in the center of the shape

No default plugins: it is not possible to

  • select cells
  • do panning

PR 493 new example

Notes

Relates to #432 and #449

ts-example - size of the maxgraph chunk:

  • custom shapes (existing ts-example): 444.45 kB
  • without defaults (the new example): 440.44 kB

js-example - size of the main bundle:

  • with codecs (existing js-example): 446.75 kB
  • without defaults (the new example): 428.83 kB

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 4, 2024
@tbouffard tbouffard changed the title feat: add a new TypeScript example that doesn't use maxGraph defaults chore: add a new example that doesn't use maxGraph defaults Aug 4, 2024
This new examples doesn't use default plugins and default style configurations:
  - edge marker
  - edge style (connector)
  - perimeter
  - shape
It will show the progress made in improving the tree-shaking for applications that don't want to use
maxGraph's default configuration.

Also improve ts-example
  - improve readme
  - update page title
  - improve style declaration: remove wrong TODO and use constants
@tbouffard tbouffard force-pushed the refactor/add_more_examples branch from 994be87 to 11004ad Compare August 7, 2024 13:30
@tbouffard tbouffard changed the title chore: add a new example that doesn't use maxGraph defaults chore: add 2 new examples that doesn't use maxGraph defaults Aug 7, 2024
@tbouffard tbouffard marked this pull request as ready for review August 16, 2024 18:51
@tbouffard tbouffard merged commit 1d84c9a into main Aug 16, 2024
@tbouffard tbouffard deleted the refactor/add_more_examples branch August 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant