fix: correctly call methods in TemporaryCellStates and PrintPreview#546
Merged
fix: correctly call methods in TemporaryCellStates and PrintPreview#546
Conversation
In the `PageBreaks` story, the print page failed to display the graph. This issue was mainly caused by maxGraph core calling functions on incorrect instances, especially when switching from regular functions to arrow functions (changing the value of `this`). This problem originated during the migration from mxGraph. Additionally, in `TemporaryCellStates`, the correct method `oldDoRedrawShape` is now called instead of `oldValidateCellState`. The addition of types helped in identifying this issue. Finally, `PrintPreview` now logs errors to the global logger, allowing easier troubleshooting in the future. The previous error was hidden, and enabling logs made it possible to trace the source of the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
PageBreaksstory, the print page failed to display the graph.This issue was mainly caused by maxGraph core calling functions on incorrect instances.
This problem originated during the migration from mxGraph, especially when switching from regular functions to arrow functions (changing the value of
this).Additionally, in
TemporaryCellStates, the correct methodoldDoRedrawShapeis now called instead ofoldValidateCellState.The addition of types helped in identifying this issue.
Finally,
PrintPreviewnow logs errors to the global logger, allowing easier troubleshooting in the future.The previous error was hidden, and enabling logs made it possible to trace the source of the problem.
Notes
Closes #535
This fix is inspired by 4ddbdf5 which partially fixed the problem.