fix: improve type of the handler parameter in factoryMethod#554
Merged
fix: improve type of the handler parameter in factoryMethod#554
factoryMethod#554Conversation
The parameter type is now `MaxPopupMenu` instead of `PopupMenuItem` which had no relation with what is implemented in the `factoryMethod` function. Also simplify nullish checks in the implementation of MaxPopupMenu and MaxToolbar. In MaxPopupMenu.addItem, use a more precise type for the funct parameter to improve guidance.
factoryMethod functionfactoryMethod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter type is now
MaxPopupMenuinstead ofPopupMenuItemwhich had no relation with whatis implemented in the
factoryMethodfunction.Also simplify nullish checks in the implementation of MaxPopupMenu and MaxToolbar.
In MaxPopupMenu.addItem, use a more precise type for the "funct" parameter to improve guidance.
Notes
Fixes #308