Skip to content

feat: allow usage of functions in CellStateStyle.edgeStyle#563

Merged
tbouffard merged 6 commits intomainfrom
feat/allow_cellStateStyle_edgeStyle_function
Nov 10, 2024
Merged

feat: allow usage of functions in CellStateStyle.edgeStyle#563
tbouffard merged 6 commits intomainfrom
feat/allow_cellStateStyle_edgeStyle_function

Conversation

@tbouffard
Copy link
Member

This was working but the type definition didn't allow it.
Some stories (mainly written in JavaScript) were already configured to use it. Some TypeScript
stories are now using it as well.

The actual support for the usage of a function was already implemented in GraphView.getEdgeStyle.

Also improve the JSDoc of EdgeStyle, in particular, code examples.

This was working but the type definition didn't allow it.
Some stories (mainly written in JavaScript) were already configured to use it. Some TypeScript
stories are now using it as well.

The actual support for the usage of a function was already implemented in `GraphView.getEdgeStyle`.

Also improve the JSDoc of EdgeStyle, in particular, code examples.
@tbouffard tbouffard added the enhancement New feature or request label Nov 7, 2024
@tbouffard tbouffard marked this pull request as ready for review November 9, 2024 16:46
@tbouffard tbouffard merged commit 530484e into main Nov 10, 2024
@tbouffard tbouffard deleted the feat/allow_cellStateStyle_edgeStyle_function branch November 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant