feat: ease configuration of handles in VertexHandler#569
Merged
Conversation
In `mxGraph`, such configuration was possible by updating some mxConstants values, but in `maxGraph`, constants are immutable. It is now possible to use `VertexHandlerConfig` to globally configure various settings like the fill color. Previously, configure such settings required to extend `VertexHandler`. A new `HandleConfig` object was added for shared settings with edge handlers which are now using it as well. Some stories hadn't been fully migrated from mxGraph: the mxGraph examples relied on updating mxConstants values to configure handles. They have been updated as well to better match the mxGraph behaviour. Lastly, it is possible to reset the properties in `HandleConfig` and `VertexHandlerConfig` to their default values by using dedicated reset functions. The stories use them at initialization to prevent side effects from other stories (as this settings apply globally).
VertexHandlerVertexHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
mxGraph, such configuration was possible by updating some mxConstants values, but inmaxGraph, constants are immutable.It is now possible to use
VertexHandlerConfigto globally configure various settings like the fill color.Previously, configure such settings required to extend
VertexHandler.A new
HandleConfigobject was added for shared settings with edge handlers which are now using itas well.
Some stories hadn't been fully migrated from mxGraph: the mxGraph examples relied on updating
mxConstants values to configure handles. They have been updated as well to better match the mxGraph
behaviour.
Lastly, it is possible to reset the properties in
HandleConfigandVertexHandlerConfigto theirdefault values by using dedicated reset functions.
The stories use them at initialization to prevent side effects from other stories (as these settings
apply globally).
Notes
Covers #192