feat: ease configuration of handles in EdgeHandler#576
Merged
Conversation
In `mxGraph`, such configuration was possible by updating some mxConstants values, but in `maxGraph`, constants are immutable. It is now possible to use `EdgeHandlerConfig` to globally configure various settings like the stroke color. Previously, configuring such settings required to extend `EdgeHandler` and its subclasses. The `HandleConfig` object has been updated to also let configure the label handles, for example, their size and fill color. The new properties are now used in `EdgeHandler` and `VertexHandler`. Lastly, it is possible to reset the properties in `EdgeHandlerConfig` to its default values by using a dedicated reset function. A new story has been added to demonstrate the effects of customizing “handle” defaults and comparing them with the original defaults.
…ze increased with the latest developments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
mxGraph, such configuration was possible by updating some mxConstants values, but inmaxGraph,constants are immutable.
It is now possible to use
EdgeHandlerConfigto globally configure various settings like the strokecolor.
Previously, configuring such settings required to extend
EdgeHandlerand its subclasses.The
HandleConfigobject has been updated to also let configure the label handles, for example,their size and fill color. The new properties are now used in
EdgeHandlerandVertexHandler.Lastly, it is possible to reset the properties in
EdgeHandlerConfigto its default values by usinga dedicated reset function.
A new story has been added to demonstrate the effects of customizing “handle” defaults and comparing
them with the original defaults.
Notes
Covers #192
Demo of the new story
PR_576_new_story_config_handles.webm