Reviewing files that changed from the base of the PR and between 997db4a and a541562.

• packages/core/src/view/handler/RubberBandHandler.ts (10 hunks)
• packages/ts-example-without-defaults/src/main.ts (1 hunks)
• packages/ts-example/src/main.ts (1 hunks)
• packages/ts-support/src/index.ts (1 hunks)

• GitHub Check: build (windows-2022)

packages/ts-example/src/main.ts (2)

117-117: Improved TypeScript syntax by using non-null assertion.

The change from explicit type casting <HTMLElement>document.querySelector('footer') to using the non-null assertion operator ! is a cleaner approach in modern TypeScript. It maintains the same type safety while being more concise.

---

121-121: Improved TypeScript syntax by using non-null assertion.

Similarly, the change to use the non-null assertion operator on the graph container selector follows the same pattern as the footer element. This approach is more idiomatic in modern TypeScript.

packages/ts-example-without-defaults/src/main.ts (2)

106-106: Improved TypeScript syntax by using non-null assertion.

The change from explicit type casting to using the non-null assertion operator ! is a cleaner approach in modern TypeScript. This matches the changes made in the other example file, maintaining consistency across the codebase.

---

110-110: Improved TypeScript syntax by using non-null assertion.

Using the non-null assertion operator for the graph container element follows the same pattern as in the other files. This consistent approach simplifies the codebase by standardizing on a single pattern for DOM element selection.

packages/ts-support/src/index.ts (3)

17-23: Added necessary imports for enhanced RubberBandHandler functionality.

The imports for CellState and RubberBandHandler have been added to support the new functionality implemented below. This is in line with the PR objective of adding more checks in the TS support package.

---

28-28: Improved TypeScript syntax by using non-null assertion.

The change from explicit type casting to using the non-null assertion operator ! on the container element is consistent with the changes made in the other TypeScript files. This ensures a uniform approach throughout the codebase.

---

35-42: Added RubberBandHandler configuration and Graph mixin method calls.

This addition serves two purposes:

1. Configures the RubberBandHandler plugin with specific settings
2. Calls methods defined in Graph mixins to ensure that TypeScript interface augmentation is correctly defined

These changes directly address the PR objective of adding more checks for TypeScript support and demonstrating the use of RubberBandHandler along with Graph mixin methods.

packages/core/src/view/handler/RubberBandHandler.ts (13)

116-119: Enhanced documentation for defaultOpacity property.

The documentation has been improved by clearly specifying the valid value range (0-100) and explicitly marking the default value using the @default tag. This makes the API more user-friendly and self-documenting.

---

123-125: Added default value documentation for enabled property.

The @default true annotation has been added to explicitly document the default value of the enabled property, improving the clarity of the API documentation.

---

139-140: Improved method reference using JSDoc link syntax.

Changed from using <update> to the more standard {@link update} syntax, improving the consistency of the documentation and enabling better IDE integration and documentation generation.

---

144-145: Improved method reference using JSDoc link syntax.

Similar to the previous change, updated the reference to use {@link update} for better documentation consistency.

---

149-151: Added default value documentation for fadeOut property.

Added the @default false annotation to explicitly document the default value of the fadeOut property, enhancing the API documentation clarity.

---

162-163: Improved method documentation clarity.

The documentation for setEnabled has been clarified to better describe what the method does, making it more straightforward for users to understand its purpose.

---

177-179: Enhanced mouseDown method documentation.

The description has been improved to better explain the purpose and behavior of the method, particularly how it handles event consumption and initiates rubberband selection.

---

241-242: Improved mouseMove method documentation.

Simplified the description to clearly state the method's purpose of updating the rubberband selection.

---

298-299: Enhanced mouseUp method documentation with proper link.

Updated the documentation to use the proper JSDoc link syntax {@link Graph#selectRegion} to reference the related method, improving cross-referencing in the documentation.

---

311-313: Improved execute method documentation.

Enhanced the description to better explain what the method does, specifically its role in resetting the handler state and selecting the current region.

---

353-354: Updated property references and improved documentation link.

Changed references to <currentX> and <currentY> to use the proper JSDoc link syntax {@link repaint}, improving documentation consistency.

---

363-365: Improved repaint method documentation.

The documentation has been updated to more precisely describe what the method does, specifically mentioning that it updates the style of the div.

---

386-388: Enhanced onDestroy method documentation.

The documentation has been improved to better explain the purpose of the method and to note that it doesn't typically need to be called manually as it's handled automatically on window unload.