Skip to content

test: improve the Graph tests#797

Merged
tbouffard merged 3 commits intomainfrom
test/update_Graph_tests
May 3, 2025
Merged

test: improve the Graph tests#797
tbouffard merged 3 commits intomainfrom
test/update_Graph_tests

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented May 2, 2025 •
edited
Loading

  • Replace Graph with BaseGraph in all tests
  • This reveals that these methods don't use registered styles but contain
    hardcoded EdgeStyle implementations
  • Prepares for future refactoring to use configuration instead of hardcoded
    edge style logic
  • Also test all EdgeStyles with isOrthogonal for consistency

Notes

Covers #767

Summary by CodeRabbit

  • Tests
    • Updated graph-related tests to use direct graph instantiation.
    • Expanded test coverage for edge styles in orthogonality checks.
    • Enhanced edge handler tests with additional edge styles and improved handler type verifications.

@tbouffard
test: improve the Graph tests
7c3ba0c 
- Replace `Graph` with `BaseGraph` in `isOrthogonal` & `createEdgeHandler` tests
- This reveals that these methods don't use registered styles but contain
  hardcoded EdgeStyle implementations
- Prepares for future refactoring to use configuration instead of hardcoded
  edge style logic
- Also test all EdgeStyles with `isOrthogonal` for consistency
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label May 2, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 2, 2025 •
edited
Loading

Walkthrough

The test suite for graph-related functionality was updated to replace the use of the createGraphWithoutPlugins() utility function with direct instantiation of the BaseGraph class. This update applies to all relevant tests, including those for the isOrthogonal, createEdgeHandler, and createHandler methods. Additionally, the set of edge styles tested in the isOrthogonal tests was expanded to include EntityRelation, SegmentConnector, and TopToBottom. A new custom edge style function was introduced for testing. Imports were adjusted accordingly, but the core test logic and assertions remain unchanged.

Changes

File(s) Change Summary
packages/core/tests/view/Graph.test.ts Replaced createGraphWithoutPlugins() with direct BaseGraph instantiation; expanded edge styles in tests including EntityRelation, SegmentConnector, and TopToBottom; introduced a new custom edge style for testing; updated imports and parameterized tests accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Test
    participant BaseGraph
    participant EdgeHandler

    Test->>BaseGraph: new BaseGraph()
    Test->>BaseGraph: isOrthogonal(CellState with various edge styles)
    BaseGraph-->>Test: Return boolean result
    Test->>BaseGraph: createEdgeHandler(edgeStyle)
    BaseGraph-->>Test: Return appropriate EdgeHandler instance
Loading

Possibly related PRs

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c3ba0c and 7dce46c.

📒 Files selected for processing (1)
  • packages/core/__tests__/view/Graph.test.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/core/tests/view/Graph.test.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build (windows-2022)
  • GitHub Check: build (ubuntu-22.04)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tbouffard tbouffard merged commit 2c51baa into main May 3, 2025
7 checks passed
@tbouffard tbouffard deleted the test/update_Graph_tests branch May 3, 2025 07:43
This was referenced May 5, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbouffard