Reviewing files that changed from the base of the PR and between 22d8c9e and 01fb58b.

• CHANGELOG.md (1 hunks)
• packages/core/__tests__/view/plugins/FitPlugin.test.ts (9 hunks)
• packages/core/src/editor/Editor.ts (1 hunks)
• packages/core/src/view/AbstractGraph.ts (3 hunks)
• packages/core/src/view/other/DragSource.ts (1 hunks)
• packages/html/stories/AutoLayout.stories.ts (2 hunks)
• packages/html/stories/Codec.stories.ts (1 hunks)
• packages/html/stories/ContextIcons.stories.ts (2 hunks)
• packages/html/stories/CustomHandlesConfiguration.stories.ts (1 hunks)
• packages/html/stories/CustomStyleDefaults.stories.ts (1 hunks)
• packages/html/stories/DynamicToolbar.stories.ts (1 hunks)
• packages/html/stories/Events.stories.ts (2 hunks)
• packages/html/stories/FileIO.stories.ts (1 hunks)
• packages/html/stories/FixedPoints.stories.ts (1 hunks)
• packages/html/stories/Manhattan.stories.ts (1 hunks)
• packages/html/stories/Orthogonal.stories.ts (2 hunks)
• packages/html/stories/PageBreaks.stories.ts (1 hunks)
• packages/html/stories/ShowRegion.stories.ts (1 hunks)
• packages/html/stories/SwimLanes.stories.ts (1 hunks)
• packages/html/stories/Toolbar.stories.ts (1 hunks)

• GitHub Check: build (windows-2022)

packages/core/src/view/AbstractGraph.ts (4)

113-113: Excellent choice to use Map for plugin storage.

Using Map<string, GraphPlugin> instead of a plain object provides better semantics for key-value storage and clearer intent for plugin management.

---

222-222: Correct JSDoc reference fix.

Good correction from mxConstants.PAGE_FORMAT_A4_PORTRAIT to PAGE_FORMAT_A4_PORTRAIT to match the actual import and constant name.

---

479-479: Proper Map initialization for plugins.

The change to use Map.set() is consistent with the new Map-based plugin storage and maintains the same functionality.

---

485-486: Breaking change improves type safety and API clarity.

The return type change from T to T | undefined is a well-justified breaking change that:

• Makes the API more explicit about potential undefined returns
• Forces consumers to handle the case where plugins might not be available
• Aligns with the Map.get() behavior which returns undefined for missing keys

This change improves type safety and makes the plugin retrieval behavior more predictable.

packages/html/stories/CustomHandlesConfiguration.stories.ts (1)

108-108: Non-null assertion is appropriate for this story context.

The ! assertion on getPlugin<ConnectionHandler>('ConnectionHandler') is justified here because:

• The story setup uses default plugins which include ConnectionHandler
• This maintains the previous behavior while adapting to the new T | undefined return type
• The story context guarantees plugin availability

packages/html/stories/CustomStyleDefaults.stories.ts (1)

82-82: Consistent and appropriate non-null assertion usage.

The ! assertion follows the same pattern as other story files and is appropriate because:

• The story uses default plugins that include ConnectionHandler
• The assertion maintains existing functionality while satisfying new type requirements
• Consistent with the adaptation pattern across all story files

packages/html/stories/Codec.stories.ts (1)

114-114: Appropriate non-null assertion for PanningHandler.

The ! assertion on getPlugin<PanningHandler>('PanningHandler') is justified because:

• PanningHandler is part of the default plugin set
• The story context guarantees plugin availability
• Maintains consistency with the adaptation pattern used across all story files

This change successfully adapts to the breaking change while preserving existing functionality.

packages/html/stories/FileIO.stories.ts (1)

73-73: Non-null assertion applied correctly for plugin retrieval
The addition of ! on getPlugin<PanningHandler>('PanningHandler') properly reflects the updated return type T | undefined and avoids compile-time errors.

packages/html/stories/Manhattan.stories.ts (1)

48-48: Non-null assertion applied correctly for plugin retrieval
Using ! on getPlugin<SelectionHandler>('SelectionHandler') aligns with the updated signature and ensures guidesEnabled can be accessed without TypeScript errors.

packages/html/stories/Events.stories.ts (2)

101-101: Non-null assertion applied correctly for plugin retrieval
The ! after getPlugin<ConnectionHandler>('ConnectionHandler') safely satisfies the new T | undefined return type before setting connectImage.

---

131-131: Non-null assertion applied correctly for plugin retrieval
Applying ! on getPlugin<PopupMenuHandler>('PopupMenuHandler') ensures the handler exists at runtime and removes TypeScript errors when assigning factoryMethod.

packages/html/stories/Orthogonal.stories.ts (2)

99-100: Non-null assertion applied correctly for plugin retrieval
The non-null assertion on getPlugin<SelectionHandler>('SelectionHandler') correctly adapts to the updated signature and enables guidesEnabled.

---

112-112: Non-null assertion applied correctly for plugin retrieval
Using ! on getPlugin<ConnectionHandler>('ConnectionHandler') properly handles the T | undefined return and allows overriding createEdgeState.

packages/html/stories/ShowRegion.stories.ts (1)

109-109: Non-null assertion applied correctly for plugin retrieval
The ! on getPlugin<PopupMenuHandler>('PopupMenuHandler') ensures the menu handler is defined before calling isMenuShowing(), satisfying the updated return type.

packages/html/stories/FixedPoints.stories.ts (1)

148-151: LGTM: Non-null assertion properly handles the new getPlugin signature.

The addition of the non-null assertion operator (!) correctly addresses the breaking change where getPlugin now returns T | undefined. This assumes the ConnectionHandler plugin is always available, which is reasonable for this story context.

However, consider adding a defensive check if there's any possibility the plugin might not be registered:

  override isConnectableCell(cell: Cell) {
-   return this.graph
-     .getPlugin<ConnectionHandler>('ConnectionHandler')!
-     .isConnectableCell(cell);
+   const connectionHandler = this.graph.getPlugin<ConnectionHandler>('ConnectionHandler');
+   return connectionHandler?.isConnectableCell(cell) ?? false;
  }

packages/html/stories/PageBreaks.stories.ts (1)

79-82: LGTM: Improved naming and proper handling of new getPlugin signature.

The changes improve code clarity in two ways:

1. Better variable naming: Renaming graphHandler to selectionHandler is more descriptive and aligns with the actual plugin type being retrieved.

2. Proper null handling: The non-null assertion (!) correctly addresses the breaking change where getPlugin now returns T | undefined.

The variable name change is consistent with similar updates across other story files mentioned in the AI summary, promoting consistent naming conventions.

packages/core/src/editor/Editor.ts (1)

2392-2402: LGTM: Clean simplification with proper undefined handling.

The removal of the explicit type annotation : PanningHandler is a good simplification since TypeScript can infer the type from the generic parameter.

Unlike other files in this PR that use non-null assertions, this implementation correctly handles the potential undefined return value using optional chaining (panningHandler &&) in the subsequent conditional statements (lines 2394, 2397, 2400). This is a more defensive approach that gracefully handles cases where the PanningHandler plugin might not be available.

CHANGELOG.md (1)

15-16: Clear documentation of breaking change.

The changelog entry accurately describes the breaking change and its impact on TypeScript users. The explanation clearly communicates that getPlugin now explicitly returns undefined when a plugin is not found, requiring developers to handle this case.

packages/html/stories/DynamicToolbar.stories.ts (1)

91-91:

Details

❓ Verification inconclusive

Verify ConnectionHandler is included in default plugins.

The non-null assertion is appropriate in this story context, but please ensure that ConnectionHandler is actually included in the plugins returned by getDefaultPlugins().

---

🏁 Script executed:

#!/bin/bash
# Verify that ConnectionHandler is included in getDefaultPlugins
ast-grep --pattern 'function getDefaultPlugins() {
  $$$
}'

Length of output: 61

---

#!/bin/bash
set -e

# Locate definition or references of getDefaultPlugins to inspect its returned plugin list
rg -n -C5 "getDefaultPlugins" .

# Check if ConnectionHandler is instantiated in the default plugins array
rg -n -C5 "new ConnectionHandler" .

---

Please confirm that ConnectionHandler is registered in getDefaultPlugins()

The non-null assertion on line 91 of the story is fine in this controlled context, but you should verify that ConnectionHandler is actually part of the default plugin set:

• File: packages/html/stories/DynamicToolbar.stories.ts (line 91)
• Inspect the getDefaultPlugins() implementation (e.g. in packages/html/src/graph/plugins/…) to ensure it returns an instance of ConnectionHandler.

packages/html/stories/Toolbar.stories.ts (1)

101-101: Consistent with other story files.

The non-null assertion follows the same pattern as other story files and is appropriate in this controlled environment. The change maintains consistency across the codebase.

packages/html/stories/SwimLanes.stories.ts (2)

84-85: Good variable renaming for clarity.

The renaming from graphHandler to selectionHandler improves code readability by making the variable purpose more explicit.

---

84-84: Verify plugin availability assumptions with non-null assertions.

The non-null assertions (!) assume that both SelectionHandler and ConnectionHandler plugins will always be available. If these plugins are not registered or available, this will cause runtime errors.

Consider whether these assumptions are safe in this context, or if defensive programming with optional chaining would be more appropriate.

Also applies to: 89-89

packages/html/stories/AutoLayout.stories.ts (1)

150-150:

Details

✅ Verification successful

Verify plugin availability for non-null assertions.

The non-null assertions assume ConnectionHandler and PopupMenuHandler plugins are always available. Ensure these plugins are guaranteed to be present in the graph configuration, or consider defensive programming approaches.

Also applies to: 222-222

---

🏁 Script executed:

#!/bin/bash
# Description: Check if these plugins are part of default plugins or explicitly added
# Expected: Find evidence that these plugins are reliably available

# Search for plugin registrations and default plugin configurations
ast-grep --pattern $'getDefaultPlugins'
echo "--- Searching for ConnectionHandler plugin references ---"
rg -A 3 -B 3 "ConnectionHandler" --type ts
echo "--- Searching for PopupMenuHandler plugin references ---"  
rg -A 3 -B 3 "PopupMenuHandler" --type ts

Length of output: 54159

---

Non-null assertions are safe: ConnectionHandler & PopupMenuHandler are included in getDefaultPlugins

• The default plugin list (core/src/view/plugins/index.ts – getDefaultPlugins()) contains both ConnectionHandler and PopupMenuHandler.
• All of the stories under packages/html/stories use getDefaultPlugins(), so graph.getPlugin<…>('…')! will never be undefined in these contexts.

No changes required.

packages/html/stories/ContextIcons.stories.ts (1)

121-121: Good variable renaming for clarity.

The renaming from graphHandler to selectionHandler improves code readability and aligns with similar improvements in other story files.