chore(deps-dev): bump typescript from 5.8.2 to 5.9.2#906
Conversation
WalkthroughBumped devDependencies in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: tbouffard
PR: maxGraph/maxGraph#774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json (~5.8.2) and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` commands because the TypeScript dependency is hoisted in the monorepo structure.
Learnt from: tbouffard
PR: maxGraph/maxGraph#774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` because it's available through this hoisted dependency in the monorepo structure.
Learnt from: tbouffard
PR: maxGraph/maxGraph#849
File: packages/html/stories/DragSource.stories.js:98-101
Timestamp: 2025-06-13T07:48:10.300Z
Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.
📚 Learning: 2025-04-22T16:34:40.309Z
Learnt from: tbouffard
PR: maxGraph/maxGraph#774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json (~5.8.2) and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` commands because the TypeScript dependency is hoisted in the monorepo structure.
Applied to files:
package.json
📚 Learning: 2025-04-22T16:34:40.309Z
Learnt from: tbouffard
PR: maxGraph/maxGraph#774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` because it's available through this hoisted dependency in the monorepo structure.
Applied to files:
package.json
| "eslint-plugin-prettier": "~5.5.4", | ||
| "prettier": "~3.6.2", | ||
| "typescript": "~5.8.2", | ||
| "typescript": "~5.9.2", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
TS 5.9.2 bump LGTM; please sanity-check workspace-wide typechecking and ESLint plugin compatibility.
- Hoisted TS at the root is consistent with prior decisions for this repo (per our earlier learnings). Good use of a tilde range to constrain to 5.9.x.
- Please verify: (1) no stray typescript entries in package packages/*, and (2) typescript-eslint + ESLint 9 continue to lint fine with TS 5.9.2.
Run this script from the repo root to validate the above quickly:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Check for stray 'typescript' deps in workspace packages =="
fd -t f package.json packages | while read -r f; do
if jq -e '.dependencies.typescript or .devDependencies.typescript' "$f" >/dev/null; then
echo "Found a stray typescript entry in: $f"
jq -r '.dependencies.typescript, .devDependencies.typescript' "$f" | sed '/null/d' | sed 's/^/ version: /'
fi
done
echo "== Show root eslint / typescript-eslint / typescript versions =="
jq -r '.devDependencies | {eslint, "typescript-eslint": .["typescript-eslint"], typescript}' package.json
echo "== Locate TS ESLint parser/plugin usage (sanity) =="
rg -nP '@typescript-eslint/(parser|eslint-plugin)' -C2 --glob '!*node_modules/*' || true
echo "== Find tsconfig files to typecheck (manual run) =="
fd -t f tsconfig.json
echo
echo "Manual follow-up (recommended):"
echo " - Install and run typecheck: npm ci && npx tsc -v && npx tsc -b --pretty false || npx tsc --noEmit"
echo " - Lint: npx eslint \"**/*.ts\""Length of output: 5502
Remove stray TypeScript dependency in packages/ts-support
A stray "typescript": "3.8.2" entry was detected in packages/ts-support/package.json, resulting in two different TS versions in the workspace. Please remove it to ensure a consistent TypeScript version across all packages.
• packages/ts-support/package.json
– Remove the typescript entry under dependencies/devDependencies (version 3.8.2).
• package.json (root)
– ✅ typescript is correctly set to ~5.9.2 alongside ESLint ~9.34.0 and @typescript-eslint ~8.41.0.
After fixing, run the suggested manual follow-up to confirm everything still type-checks and lints:
npm ci
npx tsc -v
npx tsc -b --pretty false || npx tsc --noEmit
npx eslint "**/*.ts"🤖 Prompt for AI Agents
In packages/ts-support/package.json (the package file containing the stray
TypeScript entry, around where dependencies/devDependencies are defined), remove
the "typescript": "3.8.2" entry entirely (whichever section it appears in),
ensure no other local typescript versions remain in that package.json, save the
file, then run npm ci and the provided typecheck/lint commands to verify the
workspace uses the root TypeScript (~5.9.2) and everything still type-checks and
lints.
There was a problem hiding this comment.
The "typescript": "3.8.2" entry in packages/ts-support/package.json is done on purpose.
This package validates that the core package can be used with an old version of TypeScript, so this version must be defined explicitly there. The package cannot use the same version of TS as in other packages.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
cc @coderabbitai this comment is for you: #906 (comment)
|
Also bump @types/node to fix TSC 5.9 errors.
Summary by CodeRabbit