packages/core/src/view/handler/config.ts (1)

239-245: VertexHandlerConfig extensions are coherent with handler usage

The new margin and selectionShapeMatchVertex fields, plus the clarified selectionDashed docs, align with how VertexHandler consumes them. If you want to be extra explicit, you could mention that margin is interpreted in view (screen) units, but functionally this is fine as-is.

Also applies to: 259-265, 273-281

packages/core/src/view/handler/VertexHandler.ts (2)

431-459: Harden createSelectionShape against missing state.shape and improve fallback behavior

The new selectionShapeMatchVertex branch is great, but there are a couple of robustness details worth tightening:

• new this.state.shape.constructor() assumes this.state.shape is always defined. If a consumer globally enables selectionShapeMatchVertex and some vertices have no state.shape (e.g. label-only/HTML cases), this will throw.
• When falling back to this.state.shape.constructor, the new shape doesn't get apply(this.state), so shape-specific style (e.g. arc size, rounded flags) won't be available on the selection outline, unlike the stencil path.

You can make this safer and more consistent by:

• Guarding against a missing state.shape and falling back to the rectangular selection for those cases.
• Applying the state to non-stencil shapes as well.

For example:

   createSelectionShape(bounds: Rectangle): Shape {
-    let shape: Shape;
+    let shape: Shape;

     if (VertexHandlerConfig.selectionShapeMatchVertex) {
-      const stencil = StencilShapeRegistry.get(this.state.style.shape);
-
-      if (stencil) {
-        shape = new Shape(stencil);
-        shape.apply(this.state);
-      } else {
-        // @ts-ignore known to work at runtime
-        shape = new this.state.shape.constructor();
-      }
+      const stencil = StencilShapeRegistry.get(this.state.style.shape);
+
+      if (stencil) {
+        shape = new Shape(stencil);
+        shape.apply(this.state);
+      } else if (this.state.shape) {
+        // @ts-expect-error constructor signatures differ per shape type but work at runtime
+        shape = new (this.state.shape.constructor as typeof Shape)();
+        shape.apply(this.state);
+      } else {
+        shape = new RectangleShape(
+          Rectangle.fromRectangle(bounds),
+          NONE,
+          this.getSelectionColor()
+        );
+      }
     } else {
       shape = new RectangleShape(
         Rectangle.fromRectangle(bounds),
         NONE,
         this.getSelectionColor()
       );
     }

The rest of the configuration (outline, bounds, stroke, etc.) can remain as you have it.

---

411-419: Margin is not applied during interactive resize, only after reset/redraw

getSelectionBounds expands the initial selection bounds by VertexHandlerConfig.margin, and reset/redraw copy that into this.bounds. However, during resizeVertex you recompute this.bounds directly from the unscaled geometry without reapplying the margin, and drawPreview/getSelectionBorderBounds use this.bounds as-is.

Net effect: for non-zero margin, the selection border/handles will be flush with the vertex during drag, then “jump” outward by the margin once reset/redraw runs.

If you want the margin to be visually consistent while resizing, consider:

• Keeping this.bounds as the geometry bounds; and
• Applying the margin only in getSelectionBorderBounds() (and, if desired, the sizer bounds) instead of baking it into getSelectionBounds.

That would avoid the jump without changing geometry math.

Also applies to: 1070-1080, 2035-2037

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 849
File: packages/html/stories/DragSource.stories.js:98-101
Timestamp: 2025-06-13T07:48:10.300Z
Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 776
File: packages/core/src/view/Graph.ts:77-83
Timestamp: 2025-04-24T12:33:36.243Z
Learning: All register functions in maxGraph (`registerDefaultShapes`, `registerDefaultEdgeStyles`, `registerDefaultPerimeters`, and `registerDefaultEdgeMarkers`) have internal state flags to prevent duplicate registrations, making them inherently idempotent.