Conversation
|
Preview URLs (3 pages)
Flaws (2) Note! 2 documents with no flaws that don't need to be listed. 🎉 Found an unexpected or unresolvable flaw? Please report it here. URL:
External URLs (22)URL:
URL:
URL:
(comment last updated: 2026-04-13 14:02:58) |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
641a618 to
c40605c
Compare
simoneonofri
left a comment
There was a problem hiding this comment.
Hi, I really like the flow of the document. Thank you for your hard work. I've added a first round of comments
estelle
left a comment
There was a problem hiding this comment.
Submitting the feedback i have thus far...
Co-authored-by: Estelle Weyl <[email protected]> Co-authored-by: Simone Onofri <[email protected]>
Co-authored-by: Simone Onofri <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Hamish Willee <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I've given this another pass, and I think it is in a state where it could land? Thanks again to Estelle for suggesting to split off STRIDE and LINDDUN to a separate page and thanks to Simone for the technical review! @hamishwillee what do you think? |
hamishwillee
left a comment
There was a problem hiding this comment.
The structure is much improved by splitting out the frameworks. I have given this a quick re-scan only - just highlighted a few grammatical nits. Approving as it is in a pretty good state. Not merging, because others might have further comments.
Co-authored-by: Hamish Willee <[email protected]>
This PR creates 3 new pages on threat modeling.