Skip to content

Added assignemnt 1 solution#1

Open
mehrdadmalekmo wants to merge 1 commit intomainfrom
assignment-1
Open

Added assignemnt 1 solution#1
mehrdadmalekmo wants to merge 1 commit intomainfrom
assignment-1

Conversation

@mehrdadmalekmo
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Added code the jupyter notebook of the assignment

What did you learn from the changes you have made?

Already familiar with python

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

A more efficient approach is to use dictionaries to count the number each unique charecter. This will have a better time efficiency as dictionary uses hash map and has o(1) time complexity for inserting which makes the algorithm o(n) while the sorting approach is o(nlog(n))

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

N/A

How were these changes tested?

Using the test inputs given in the notebook

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants