Fix for React Maximum update depth exceeded errror on search result pages #141
Open
distoai[bot] wants to merge 2 commits intomainfrom
Open
Fix for React Maximum update depth exceeded errror on search result pages #141distoai[bot] wants to merge 2 commits intomainfrom
distoai[bot] wants to merge 2 commits intomainfrom
Conversation
added 2 commits
July 14, 2023 19:10
…riant function. To fix the issue, we need to modify the useCalculatedNavLinkVariant function to prevent the infinite loop.
…NavLinkVariant function. To fix the issue, we need to add the authenticatedUser dependency to the dependency array of the useLayoutEffect hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause:
The React Maximum update depth exceeded error is occurring on the search result pages.
Steps to fix:
The error is caused by an infinite loop in the useCalculatedNavLinkVariant function. To fix the issue, we need to modify the useCalculatedNavLinkVariant function to prevent the infinite loop.
The error is also caused by a missing dependency in the useCalculatedNavLinkVariant function. To fix the issue, we need to add the authenticatedUser dependency to the dependency array of the useLayoutEffect hook.